#16 use the request path in the exception #17
Conversation
|
Good solution! Want to update the accompanying text to something more about the "path" than the "request handler"? |
adafruit_wsgi/wsgi_app.py
Outdated
| "Proper HTTP response return not given for request handler '{}'".format( | ||
| route["func"].__name__ | ||
| ) | ||
| f"Proper HTTP response return not given for request handler for path \ |
There was a problem hiding this comment.
I checked this out, and it seems this will be raised and catch the tabs as follows:
RuntimeError: Proper HTTP response return not given for request handler for path 'some/path/'
Try this out, I think this should both appease pylint and keep the words together:
"Proper HTTP response return not given for request handler for path "
f"'{request.path}'"Note the space after path in the first line!
There was a problem hiding this comment.
That should be better there. It didn't need to be f-stringed, as it is already typed as a string, so a simple concatenation should be good enough
adafruit_wsgi/wsgi_app.py
Outdated
| route["func"].__name__ | ||
| ) | ||
| "Proper HTTP response not returned by request handler for path " | ||
| + "'{request.path}'" |
There was a problem hiding this comment.
Looks like the f is missing for the f-string
There was a problem hiding this comment.
Facepalm. Fixed it.
Updating https://github.com/adafruit/Adafruit_CircuitPython_WSGI to 1.1.10 from 1.1.9: > Merge pull request adafruit/Adafruit_CircuitPython_WSGI#17 from dannystaple/16/use-request-path-in-exception > Patch .pre-commit-config.yaml > change discord badge > Patch: Replaced discord badge image > Update .gitignore > Update Black to latest.
Fixes #16.
Output looks like: